1141207 - GTK3 build fails undefined reference to `gtk_print_settings_foreach'

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

Looks like fallout from bug 1090448.

13:04.14 ../../widget/gtk/Unified_cpp_widget_gtk1.o: In function `nsPrintOptionsGTK::SerializeToPrintData(nsIPrintSettings*, nsIWebBrowserPrint*, mozilla::embedding::PrintData*)':
13:04.14 /home/kbrosnan/src/mc-clone/widget/gtk/nsPrintOptionsGTK.cpp:57: undefined reference to `gtk_print_settings_foreach'
13:04.14 collect2: error: ld returned 1 exit status
13:04.15 /home/kbrosnan/src/mc-clone/config/rules.mk:812: recipe for target 'libxul.so' failed
13:04.15 gmake[5]: *** [libxul.so] Error 1

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Huh... strange. gtk_print_settings_foreach is apparently available for GTK3:

https://developer.gnome.org/gtk3/stable/GtkPrintSettings.html#gtk-print-settings-foreach

Or am I missing something here?

Comment 2

[Karl Tomlinson (:karlt)]

We need to an entry in http://hg.mozilla.org/mozilla-central/annotate/23f1f0369df5/widget/gtk/mozgtk/mozgtk.c

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

Attachment: 1141207-gtk3-widget-fix.patch

Add gtk_print_settings_foreach - builds successfully.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5751919a5042

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

Try looks green.

Comment 5

[Mike Hommey [:glandium] OoO back on Apr 15]

You should do another try with this patch applied:
https://bugzilla.mozilla.org/attachment.cgi?id=8444892

(expect plenty of orange and red, but at least it should build)

Comment 6

[Carsten Book [:Tomcat]]

(In reply to Kevin Brosnan [:kbrosnan] from comment #4)
> Try looks green.

so with comment 5 this needs another try run ?

Comment 7

[Mike Hommey [:glandium] OoO back on Apr 15]

You can land this, I verified it works.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5cb314c34f24

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5cb314c34f24